reflink

Review Request #270 - Created Dec. 17, 2015 and updated

Information
Matthew Ahrens
illumos-gate
Reviewers
mahrens

reflink


  

Issues

  • 10
  • 0
  • 0
  • 10
Description From Last Updated
Looks like you inadvertently reformatted a lot of this file. Matthew Ahrens Matthew Ahrens
ah, looks like thankfully this function is not used. Matthew Ahrens Matthew Ahrens
this always returns 0, not sure what the point is. Matthew Ahrens Matthew Ahrens
you don't seem to use the db, not sure what the point of this is. Matthew Ahrens Matthew Ahrens
I'm surprised that this works. Matthew Ahrens Matthew Ahrens
wrong operator precedence, this sets error to the boolean value (zfs_acl_ids_create() != 0) Matthew Ahrens Matthew Ahrens
do reflinks work if you are not using System Attributes? Matthew Ahrens Matthew Ahrens
if you crash after this, then the new on-disk file will be leaked. Matthew Ahrens Matthew Ahrens
You need to do the appropriate dmu_tx_hold_*'s before making this change. It looks like dmu_tx_hold_sa_create() can do this for you. Matthew Ahrens Matthew Ahrens
You aren't storing the refnode <-> clones relationship on disk. Matthew Ahrens Matthew Ahrens
Matthew Ahrens

It looks like you've just started this project and there's a lot of work to do.

usr/src/uts/common/fs/zfs/zfs_vnops.c (Diff revision 1)
 
 

Looks like you inadvertently reformatted a lot of this file.

usr/src/uts/common/fs/zfs/zfs_vnops.c (Diff revision 1)
 
 

ah, looks like thankfully this function is not used.

usr/src/uts/common/fs/zfs/zfs_vnops.c (Diff revision 1)
 
 

this always returns 0, not sure what the point is.

usr/src/uts/common/fs/zfs/zfs_vnops.c (Diff revision 1)
 
 

you don't seem to use the db, not sure what the point of this is.

usr/src/uts/common/fs/zfs/zfs_vnops.c (Diff revision 1)
 
 

I'm surprised that this works.

usr/src/uts/common/fs/zfs/zfs_vnops.c (Diff revision 1)
 
 

wrong operator precedence, this sets error to the boolean value (zfs_acl_ids_create() != 0)

usr/src/uts/common/fs/zfs/zfs_vnops.c (Diff revision 1)
 
 

do reflinks work if you are not using System Attributes?

usr/src/uts/common/fs/zfs/zfs_vnops.c (Diff revision 1)
 
 
 

if you crash after this, then the new on-disk file will be leaked.

usr/src/uts/common/fs/zfs/zfs_vnops.c (Diff revision 1)
 
 
You need to do the appropriate dmu_tx_hold_*'s before making this change.  It looks like dmu_tx_hold_sa_create() can do this for you.
usr/src/uts/common/fs/zfs/zfs_vnops.c (Diff revision 1)
 
 
 
 
 
 
 
 
 
 

You aren't storing the refnode <-> clones relationship on disk.

Loading...