zfs send -p -I: send properties only for snapshots that are actually sent
Review Request #141 - Created Dec. 2, 2014 and discarded
... as opposed to sending properties of all snapshots of the relevant
filesystem. The previous behavior results in properties being set on
all snapshots on the receiving side, which is quite slow.
Behavior of zfs send -R is not changed.
Note that send_iterate_fs() now has to iterate snapshots in their
Only FreeBSD and ZoL. None for illumos.
|As @dweeezil correctly noted this simple solution breaks several usecases. First, zfs recv -F is broken because to implement it ...||Andriy Gapon|
Please check out an issue related to this in https://github.com/zfsonlinux/zfs/pull/2907 and my proposed fix. In short, the incomplete snapshot list can cause Bad Things™ to happen during "zfs receive -F".
As @dweeezil correctly noted this simple solution breaks several usecases.
First, zfs recv -F is broken because to implement it the receiving side needs to know about all snpashots that exist on the sending side.
Another bug is that the properties are not included into a full stream produced with zfs send -p pool/ds@snap.
Most likely the original performance issue better be fixed at the receiving end.